Alon Bar-Lev has posted comments on this change.
Change subject: core: Add builder functions to create ParametersMap
......................................................................
Patch Set 3:
(1 comment)
forgot to publish this in previous round.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ParameterHelper.java
Line 5: import org.ovirt.engine.core.common.action.VdcActionParametersBase;
Line 6: import org.ovirt.engine.core.compat.TransactionScopeOption;
Line 7: import org.ovirt.engine.core.common.action.VdcActionType;
Line 8:
Line 9: public class ParameterHelper {
please add comment that this class is needed to be in common as it is shared
between frontend and backend, in future when this will no longer the case, we
collapse these into command base and query base.
Line 10:
Line 11: /**
Line 12: * Used by front and api to generate a map with default values
Line 13: * for VdcActionParametersBase
--
To view, visit http://gerrit.ovirt.org/21737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie12d4f76ed68e8449e3ea24839c4360bbea93b35
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
