Greg Padgett has posted comments on this change.
Change subject: Add support for maintenance mode reporting
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
Looks good, just one nuance in how the stats are retrieved.
....................................................
File src/ovirt_hosted_engine_setup/vm_status.py
Line 63: all_host_stats = {}
Line 64:
Line 65: try:
Line 66: cluster_stats = ha_cli.get_all_stats(client.HAClient.
Line 67: StatModes.GLOBAL)[0]
There won't be a [0] entry if global maintenance has never been enabled;
probably should let KeyError pass without error.
Line 68: except (socket.error, KeyError, AttributeError, IndexError):
Line 69: sys.stderr.write(
Line 70: _('Cannot connect to the HA daemon, please check the
logs.\n')
Line 71: )
--
To view, visit http://gerrit.ovirt.org/21648
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib21774d33fd50bc1da47a60b6fd48859ca27cfda
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
