Lior Vernia has uploaded a new change for review.
Change subject: core: Fixed error in VdsNetworkInterface.equals()
......................................................................
core: Fixed error in VdsNetworkInterface.equals()
Seems like the network name wasn't in fact checked as intended; the
check as it's currently implemented should always return false.
Change-Id: I441ad028fc72815479966ef6befd9f925fa3f293
Signed-off-by: Lior Vernia <lver...@redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/80/21780/1
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java
index 4c75a56..f3e22d6 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java
@@ -435,7 +435,7 @@
if (bootProtocol != other.bootProtocol) {
return false;
}
- if (!ObjectUtils.objectsEqual(other.networkName, other.networkName)) {
+ if (!ObjectUtils.objectsEqual(networkName, other.networkName)) {
return false;
}
if (bridged != other.bridged) {
--
To view, visit http://gerrit.ovirt.org/21780
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I441ad028fc72815479966ef6befd9f925fa3f293
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
