Sahina Bose has uploaded a new change for review. Change subject: restapi: Deprecate replace brick from API ......................................................................
restapi: Deprecate replace brick from API The replace brick action is no longer supported in gluster. User needs to migrate and remove brick instead. Marking the API as deprecated. Change-Id: I5ce8126324a6e9575d978cbdd136e78a6bd90626 Bug-Url: https://bugzilla.redhat.com/957602 Signed-off-by: Sahina Bose <sab...@redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterBrickResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 2 files changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/77/21777/1 diff --git a/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterBrickResource.java b/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterBrickResource.java index 8c3eb78..611d236 100644 --- a/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterBrickResource.java +++ b/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterBrickResource.java @@ -13,8 +13,8 @@ import org.ovirt.engine.api.model.Actionable; import org.ovirt.engine.api.model.GlusterBrick; import org.ovirt.engine.api.resource.ActionResource; -import org.ovirt.engine.api.resource.MeasurableResource; import org.ovirt.engine.api.resource.ApiMediaType; +import org.ovirt.engine.api.resource.MeasurableResource; /** * Resource interface for the "clusters/{cluster_id}/glustervolumes/{volume_id}/bricks/{brick_id}" resource @@ -35,6 +35,7 @@ * @param action * @return */ + @Deprecated @POST @Formatted @Consumes({ ApiMediaType.APPLICATION_XML, ApiMediaType.APPLICATION_JSON, ApiMediaType.APPLICATION_X_YAML }) diff --git a/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml b/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml index 2f6520d..ef1664c 100644 --- a/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml +++ b/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml @@ -3834,8 +3834,8 @@ headers: Content-Type: {value: application/xml|json, required: true} Correlation-Id: {value: 'any string', required: false} -- name: /api/clusters/{cluster:id}/glustervolumes/{glustervolume:id}/bricks/{brick:id}/replace|rel=replace - description: replace the specified brick with a new brick directory in the gluster volume attached to the cluster +- name: /api/clusters/{cluster:id}/glustervolumes/{glustervolume:id}/bricks/{brick:id}/replace|rel=replace #deprecated, replaced by 'migrate/delete' + description: This is deprecated.Use migrate and delete instead. request: body: parameterType: Action @@ -3843,6 +3843,7 @@ - mandatoryArguments: {action.brick.server_id: 'xs:string', action.brick.brick_dir: 'xs:string'} optionalArguments: {action.force: 'xs:boolean'} description: replace the specified brick with a new brick directory in the gluster volume attached to the cluster + deprecated: true urlparams: {} headers: Content-Type: {value: application/xml|json, required: true} -- To view, visit http://gerrit.ovirt.org/21777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5ce8126324a6e9575d978cbdd136e78a6bd90626 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sahina Bose <sab...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches