Sahina Bose has posted comments on this change.
Change subject: gluster:fix remove brick validator
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/gluster/GlusterBrickValidator.java
Line 24: public ValidationResult canRemoveBrick(List<GlusterBrickEntity>
bricks,
Line 25: GlusterVolumeEntity volumeEntity,
Line 26: int replicaCount, boolean forceRemove) {
Line 27: if (replicaCount == 0) {
Line 28: replicaCount = volumeEntity.getReplicaCount();
I din't realise you were not using this to pass to the gluster command. So this
is ok
Line 29: }
Line 30: if (bricks.isEmpty()) {
Line 31: return new
ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_BRICKS_REQUIRED);
Line 32: }
--
To view, visit http://gerrit.ovirt.org/21745
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id845f27f01c022c1fdc3240fcf3a7b5a95563bb4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
