Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: update legacy DB params reading ......................................................................
Patch Set 1: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/legacy/database.py Line 80: } Line 81: self.environment[ Line 82: osetupcons.CoreEnv.LEGACY_PG_CREDS_FOUND Line 83: ] = True Line 84: break can you comment about why the first line not referring to postgres user is the right one (and not the last of the file)? Line 85: Line 86: @plugin.event( Line 87: stage=plugin.Stages.STAGE_SETUP, Line 88: before=( -- To view, visit http://gerrit.ovirt.org/21706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1aeb66ecaceecc5f4daa71416ab3306305f6802 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
