Ravi Nori has posted comments on this change. Change subject: engine : Remove dependency of IdQueryParameters from GetRoleByIdQuery ......................................................................
Patch Set 17: (1 comment) .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendRolesResource.java Line 49: } Line 50: Line 51: @Override Line 52: protected <T extends VdcParametersMap, P> T getQueryParams(Class<? extends VdcParametersMap> queryParamsClass, P id) { Line 53: return (T) VdcParameterHelper.buildQueryParametersMap().put(SlaVdcParameters.RoleId, (Serializable) id); Can you please elaborate on your comment. Line 54: } Line 55: Line 56: @Override Line 57: public Response performRemove(String id) { -- To view, visit http://gerrit.ovirt.org/20415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67fb4920f8107575dd26e173456a7edf99c3503f Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches