Ravi Nori has posted comments on this change.

Change subject: engine : Validate parameter in canDoAction
......................................................................


Patch Set 2:

(2 comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VdcParametersValidator.java
Line 39:             CoreVdcParameters.HTTP_SESSION_ID,
Line 40:             CoreVdcParameters.FILTERED,
Line 41:             CoreVdcParameters.REFRESH);
Line 42: 
Line 43:     public static boolean validateParameters(
Will look into it
Line 44:             VdcParametersMap parameters,
Line 45:             List<VdcParameter> requiredParameters,
Line 46:             List<VdcParameter> optionalParameters) {
Line 47:         if (requiredParameters.isEmpty()) {


Line 72:                 buf.append(param.getName());
Line 73:             }
Line 74:             log.warnFormat("Unknown parameters {0} found in command.", 
buf.toString());
Line 75:         }
Line 76:         return true;
Ok will change
Line 77:     }
Line 78: 


-- 
To view, visit http://gerrit.ovirt.org/21485
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15566c9177da28b2d47bbb6018fbfb61defcf3da
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to