Vojtech Szocs has uploaded a new change for review. Change subject: core: Add no-argument constructor check ......................................................................
core: Add no-argument constructor check This patch adds NoArgConstructorCheck to ensure all classes in backend common module have no-argument constructor (with any access modifier), unless excluded via checkstyle-suppressions.xml file. Added public no-argument constructor to all Parameters classes. Added classes unrelated to GWT RPC mechanism (and therefore irrelevant for this check) into checkstyle-suppressions.xml file. Change-Id: Ia4f9a00d6289374b433ed4419552420a3337da50 Bug-Url: https://bugzilla.redhat.com/1029605 Signed-off-by: Vojtech Szocs <vsz...@redhat.com> --- M backend/manager/modules/common/pom.xml M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAgentFenceOptionsQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DownloadImageVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ExtendVmDiskSizeVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/FullListVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDevicesVisibilityVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskAlignmentVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskImageAlignmentVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskLunAlignmentVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetVmStatsVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MomPolicyVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SnapshotVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UploadImageVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VmNicDeviceVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/AddGlusterServerVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/CreateGlusterVolumeVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterHookVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterServiceVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterServicesListVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeActionVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeAdvancedDetailsVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeBricksActionVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeBricksVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeOptionVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeProfileInfoVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeRebalanceVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeRemoveBricksVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumesListVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/RemoveGlusterServerVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/ReplaceGlusterVolumeBrickActionVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/ResetGlusterVolumeOptionsVDSParameters.java A build-tools-root/checkstyles/src/main/resources/checkstyle-suppressions.xml M build-tools-root/checkstyles/src/main/resources/checkstyle.xml A build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NoArgConstructorCheck.java M pom.xml 37 files changed, 169 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/33/21733/1 diff --git a/backend/manager/modules/common/pom.xml b/backend/manager/modules/common/pom.xml index 0a45d19..817b564 100644 --- a/backend/manager/modules/common/pom.xml +++ b/backend/manager/modules/common/pom.xml @@ -68,6 +68,7 @@ <configuration> <propertyExpansion>disallowFinals=true</propertyExpansion> <propertyExpansion>disallowMemberInit=true</propertyExpansion> + <propertyExpansion>checkNoArgConstructor=true</propertyExpansion> </configuration> </plugin> <plugin> diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAgentFenceOptionsQueryParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAgentFenceOptionsQueryParameters.java index c26aaba..06838ab 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAgentFenceOptionsQueryParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAgentFenceOptionsQueryParameters.java @@ -16,4 +16,7 @@ super(); this.version = version; } + + public GetAgentFenceOptionsQueryParameters() { + } } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DownloadImageVDSCommandParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DownloadImageVDSCommandParameters.java index 76dc7ba..410cc91 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DownloadImageVDSCommandParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DownloadImageVDSCommandParameters.java @@ -15,6 +15,9 @@ this.downloadInfo = downloadInfo; } + public DownloadImageVDSCommandParameters() { + } + public LocationInfo getDownloadInfo() { return downloadInfo; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ExtendVmDiskSizeVDSCommandParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ExtendVmDiskSizeVDSCommandParameters.java index 455f6fe..c1a2ffa 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ExtendVmDiskSizeVDSCommandParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ExtendVmDiskSizeVDSCommandParameters.java @@ -28,6 +28,9 @@ this.newSize = newSize; } + public ExtendVmDiskSizeVDSCommandParameters() { + } + public long getNewSize() { return newSize; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/FullListVDSCommandParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/FullListVDSCommandParameters.java index 3a0bbf0..278bec6 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/FullListVDSCommandParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/FullListVDSCommandParameters.java @@ -16,6 +16,9 @@ this.vmIds = vmIds; } + public FullListVDSCommandParameters() { + } + public List<String> getVmIds() { return vmIds; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDevicesVisibilityVDSCommandParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDevicesVisibilityVDSCommandParameters.java index 0cf86e6..11e6650 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDevicesVisibilityVDSCommandParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDevicesVisibilityVDSCommandParameters.java @@ -13,6 +13,9 @@ this.devicesIds = devicesIds; } + public GetDevicesVisibilityVDSCommandParameters() { + } + public String[] getDevicesIds() { return devicesIds; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskAlignmentVDSCommandParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskAlignmentVDSCommandParameters.java index 1748916..30c6943 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskAlignmentVDSCommandParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskAlignmentVDSCommandParameters.java @@ -10,5 +10,8 @@ super(vdsId, vmId); } + public GetDiskAlignmentVDSCommandParameters() { + } + public abstract Map<String, String> getDriveSpecs(); } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskImageAlignmentVDSCommandParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskImageAlignmentVDSCommandParameters.java index 102137c..4b16a9a 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskImageAlignmentVDSCommandParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskImageAlignmentVDSCommandParameters.java @@ -13,6 +13,9 @@ super(vdsId, vmId); } + public GetDiskImageAlignmentVDSCommandParameters() { + } + public void setPoolId(Guid poolId) { this.poolId = poolId; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskLunAlignmentVDSCommandParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskLunAlignmentVDSCommandParameters.java index acbd9dd..d00afed 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskLunAlignmentVDSCommandParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskLunAlignmentVDSCommandParameters.java @@ -13,6 +13,9 @@ super(vdsId, vmId); } + public GetDiskLunAlignmentVDSCommandParameters() { + } + public void setLunId(String lunId) { this.lunId = lunId; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetVmStatsVDSCommandParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetVmStatsVDSCommandParameters.java index 9c2a172..7bea3fe 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetVmStatsVDSCommandParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetVmStatsVDSCommandParameters.java @@ -12,6 +12,9 @@ this.vds = vds; } + public GetVmStatsVDSCommandParameters() { + } + /** * @return the vds */ diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MomPolicyVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MomPolicyVDSParameters.java index ed90b6e..051ea41 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MomPolicyVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MomPolicyVDSParameters.java @@ -13,6 +13,9 @@ this.enableBalloon = enableBalloon; } + public MomPolicyVDSParameters() { + } + public boolean isEnableBalloon() { return enableBalloon; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java index 2b12a64..1c20b14 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java @@ -47,6 +47,9 @@ this.interfaces = (interfaces == null) ? new ArrayList<VdsNetworkInterface>() : interfaces; } + public SetupNetworksVdsCommandParameters() { + } + public List<Network> getNetworks() { return networks; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SnapshotVDSCommandParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SnapshotVDSCommandParameters.java index a7916ea..85ad275 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SnapshotVDSCommandParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SnapshotVDSCommandParameters.java @@ -21,6 +21,9 @@ this.memoryVolume = memoryVolume; } + public SnapshotVDSCommandParameters() { + } + public List<DiskImage> getImages() { return images; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UploadImageVDSCommandParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UploadImageVDSCommandParameters.java index 434219d..6c6d026 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UploadImageVDSCommandParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UploadImageVDSCommandParameters.java @@ -15,6 +15,9 @@ this.uploadInfo = uploadInfo; } + public UploadImageVDSCommandParameters() { + } + public LocationInfo getUploadInfo() { return uploadInfo; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VmNicDeviceVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VmNicDeviceVDSParameters.java index 6656e2b..d0565c1 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VmNicDeviceVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VmNicDeviceVDSParameters.java @@ -18,6 +18,9 @@ this.vmDevice = vmDevice; } + public VmNicDeviceVDSParameters() { + } + public VM getVm() { return vm; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/AddGlusterServerVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/AddGlusterServerVDSParameters.java index d9ab696..a304217 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/AddGlusterServerVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/AddGlusterServerVDSParameters.java @@ -16,6 +16,9 @@ setHostnameOrIp(hostnameOrIp); } + public AddGlusterServerVDSParameters() { + } + public String getHostnameOrIp() { return hostnameOrIp; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/CreateGlusterVolumeVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/CreateGlusterVolumeVDSParameters.java index 3a156b3..ecc3f88 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/CreateGlusterVolumeVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/CreateGlusterVolumeVDSParameters.java @@ -18,6 +18,9 @@ setVolume(volume); } + public CreateGlusterVolumeVDSParameters() { + } + public GlusterVolumeEntity getVolume() { return volume; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterHookVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterHookVDSParameters.java index b8eff48..dc04939 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterHookVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterHookVDSParameters.java @@ -60,6 +60,9 @@ setEnabled(enabled); } + public GlusterHookVDSParameters() { + } + public String getHookContent() { return content; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterServiceVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterServiceVDSParameters.java index aa16611..7fc567b 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterServiceVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterServiceVDSParameters.java @@ -15,6 +15,9 @@ this.actionType = actionType; } + public GlusterServiceVDSParameters() { + } + public List<String> getServiceList() { return serviceList; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterServicesListVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterServicesListVDSParameters.java index 7f0fb89..bbec38e 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterServicesListVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterServicesListVDSParameters.java @@ -16,6 +16,9 @@ this.serviceNames = serviceNames; } + public GlusterServicesListVDSParameters() { + } + public Set<String> getServiceNames() { return serviceNames; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeActionVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeActionVDSParameters.java index 1127acf..33717c7 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeActionVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeActionVDSParameters.java @@ -14,6 +14,9 @@ setForceAction(forceAction); } + public GlusterVolumeActionVDSParameters() { + } + public void setForceAction(boolean forceAction) { this.forceAction = forceAction; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeAdvancedDetailsVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeAdvancedDetailsVDSParameters.java index b8fd5b7..ad81e4e 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeAdvancedDetailsVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeAdvancedDetailsVDSParameters.java @@ -22,6 +22,9 @@ this.detailRequired = detailRequired; } + public GlusterVolumeAdvancedDetailsVDSParameters() { + } + public Guid getClusterId() { return clusterId; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeBricksActionVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeBricksActionVDSParameters.java index ac2197a..9206a1d 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeBricksActionVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeBricksActionVDSParameters.java @@ -19,6 +19,8 @@ this.stripeCount = stripeCount; } + public GlusterVolumeBricksActionVDSParameters() { + } public int getReplicaCount() { return replicaCount; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeBricksVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeBricksVDSParameters.java index 7931561..32f1249 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeBricksVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeBricksVDSParameters.java @@ -15,6 +15,9 @@ this.bricks = bricks; } + public GlusterVolumeBricksVDSParameters() { + } + public List<GlusterBrickEntity> getBricks() { return bricks; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeOptionVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeOptionVDSParameters.java index 61ba8a5..29bd9ea 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeOptionVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeOptionVDSParameters.java @@ -15,6 +15,9 @@ this.volumeOption = volumeOption; } + public GlusterVolumeOptionVDSParameters() { + } + public GlusterVolumeOptionEntity getVolumeOption() { return volumeOption; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeProfileInfoVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeProfileInfoVDSParameters.java index afeb798..87c2157 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeProfileInfoVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeProfileInfoVDSParameters.java @@ -14,6 +14,9 @@ this.clusterId = clusterId; } + public GlusterVolumeProfileInfoVDSParameters() { + } + public Guid getClusterId() { return clusterId; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeRebalanceVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeRebalanceVDSParameters.java index bd1bb67..3b06e1e 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeRebalanceVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeRebalanceVDSParameters.java @@ -20,6 +20,9 @@ this.forceAction = forceAction; } + public GlusterVolumeRebalanceVDSParameters() { + } + public boolean isFixLayoutOnly() { return fixLayoutOnly; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeRemoveBricksVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeRemoveBricksVDSParameters.java index c5cb90a..24cd9ae 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeRemoveBricksVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeRemoveBricksVDSParameters.java @@ -26,6 +26,9 @@ this.replicaCount = replicaCount; } + public GlusterVolumeRemoveBricksVDSParameters() { + } + public List<GlusterBrickEntity> getBricks() { return bricks; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeVDSParameters.java index 71af248..f321ebf 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeVDSParameters.java @@ -16,6 +16,9 @@ this.volumeName = volumeName; } + public GlusterVolumeVDSParameters() { + } + public String getVolumeName() { return volumeName; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumesListVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumesListVDSParameters.java index a660979..7f5d87b 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumesListVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumesListVDSParameters.java @@ -15,6 +15,9 @@ this.clusterId = clusterId; } + public GlusterVolumesListVDSParameters() { + } + public Guid getClusterId() { return clusterId; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/RemoveGlusterServerVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/RemoveGlusterServerVDSParameters.java index 43d282f..4ab922d 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/RemoveGlusterServerVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/RemoveGlusterServerVDSParameters.java @@ -17,6 +17,9 @@ setForceAction(forceAction); } + public RemoveGlusterServerVDSParameters() { + } + public String getHostnameOrIp() { return hostnameOrIp; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/ReplaceGlusterVolumeBrickActionVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/ReplaceGlusterVolumeBrickActionVDSParameters.java index dd17396..4a961a8 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/ReplaceGlusterVolumeBrickActionVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/ReplaceGlusterVolumeBrickActionVDSParameters.java @@ -28,6 +28,9 @@ setNewBrickDir(newBrickDirectory); } + public ReplaceGlusterVolumeBrickActionVDSParameters() { + } + public GlusterTaskOperation getAction() { return action; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/ResetGlusterVolumeOptionsVDSParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/ResetGlusterVolumeOptionsVDSParameters.java index b1a63e2..c7eda7d 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/ResetGlusterVolumeOptionsVDSParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/ResetGlusterVolumeOptionsVDSParameters.java @@ -19,6 +19,9 @@ this.forceAction = forceAction; } + public ResetGlusterVolumeOptionsVDSParameters() { + } + public GlusterVolumeOptionEntity getVolumeOption() { return volumeOption; } diff --git a/build-tools-root/checkstyles/src/main/resources/checkstyle-suppressions.xml b/build-tools-root/checkstyles/src/main/resources/checkstyle-suppressions.xml new file mode 100644 index 0000000..037ea10 --- /dev/null +++ b/build-tools-root/checkstyles/src/main/resources/checkstyle-suppressions.xml @@ -0,0 +1,12 @@ +<?xml version="1.0"?> +<!DOCTYPE suppressions PUBLIC "-//Puppy Crawl//DTD Suppressions 1.1//EN" "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd";> +<suppressions> + <suppress checks="checks.NoArgConstructorCheck" files=".*Test\.java"/> + <suppress checks="checks.NoArgConstructorCheck" files="VersionStorageFormatUtil.java"/> + <suppress checks="checks.NoArgConstructorCheck" files="ListUtils.java"/> + <suppress checks="checks.NoArgConstructorCheck" files="MapBackedPreferences.java"/> + <suppress checks="checks.NoArgConstructorCheck" files="Event.java"/> + <suppress checks="checks.NoArgConstructorCheck" files="EventResult.java"/> + <suppress checks="checks.NoArgConstructorCheck" files="LocationInfo.java"/> + <suppress checks="checks.NoArgConstructorCheck" files="HttpLocationInfo.java"/> +</suppressions> \ No newline at end of file diff --git a/build-tools-root/checkstyles/src/main/resources/checkstyle.xml b/build-tools-root/checkstyles/src/main/resources/checkstyle.xml index 77fc4a6..11d7cb1 100644 --- a/build-tools-root/checkstyles/src/main/resources/checkstyle.xml +++ b/build-tools-root/checkstyles/src/main/resources/checkstyle.xml @@ -28,5 +28,8 @@ <module name="checks.NoMemberInitializationCheck"> <property name="run" value="${disallowMemberInit}" default="false"/> </module> + <module name="checks.NoArgConstructorCheck"> + <property name="run" value="${checkNoArgConstructor}" default="false"/> + </module> </module> -</module> +</module> \ No newline at end of file diff --git a/build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NoArgConstructorCheck.java b/build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NoArgConstructorCheck.java new file mode 100644 index 0000000..a1a0b21 --- /dev/null +++ b/build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NoArgConstructorCheck.java @@ -0,0 +1,56 @@ +package checks; + +import com.puppycrawl.tools.checkstyle.api.AnnotationUtility; +import com.puppycrawl.tools.checkstyle.api.Check; +import com.puppycrawl.tools.checkstyle.api.DetailAST; +import com.puppycrawl.tools.checkstyle.api.TokenTypes; + +/** + * Make sure that classes have no-argument constructor (with any access modifier), i.e. either explicit or <a + * href="http://docs.oracle.com/javase/specs/jls/se7/html/jls-8.html#jls-8.8.9";>default</a> constructor without + * arguments. + */ +public class NoArgConstructorCheck extends Check { + + private boolean run = true; + + public void setRun(boolean run) { + this.run = run; + } + + @Override + public int[] getDefaultTokens() { + return new int[] { TokenTypes.CLASS_DEF }; + } + + @Override + public void visitToken(DetailAST classDef) { + if (!run) { + return; + } + + DetailAST objBlock = classDef.findFirstToken(TokenTypes.OBJBLOCK); + DetailAST child = objBlock.getFirstChild(); + boolean hasExplicitCtor = false; + + while (child != null) { + if (child.getType() == TokenTypes.CTOR_DEF) { + hasExplicitCtor = true; + DetailAST ctorParams = child.findFirstToken(TokenTypes.PARAMETERS); + if (ctorParams.getChildCount() == 0) { + // Found no-argument constructor + return; + } + } + child = child.getNextSibling(); + } + + if (hasExplicitCtor) { + DetailAST classIdent = classDef.findFirstToken(TokenTypes.LITERAL_CLASS).getNextSibling(); + log(classIdent.getLineNo(), classIdent.getColumnNo(), + "Class {0} must have a no-argument constructor (with any access modifier)", + classIdent.getText()); + } + } + +} diff --git a/pom.xml b/pom.xml index 3f1383e..e89bcc5 100644 --- a/pom.xml +++ b/pom.xml @@ -423,6 +423,7 @@ <consoleOutput>true</consoleOutput> <includeTestSourceDirectory>true</includeTestSourceDirectory> <configLocation>checkstyle.xml</configLocation> + <suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation> <propertyExpansion>runNlsCheck=false</propertyExpansion> </configuration> <executions> -- To view, visit http://gerrit.ovirt.org/21733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia4f9a00d6289374b433ed4419552420a3337da50 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
