Ramesh N has posted comments on this change.

Change subject: webadmin: allow bricks in root partition
......................................................................


Patch Set 6: Verified+1

(1 comment)

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java
Line 275:         }
Line 276:         else {
Line 277:             infoLabel.setText(null);
Line 278:         }
Line 279: 
I think you should get the visible status from model and set the visibility of 
the warning, Otherwise if you open and close the add bricks dialog box in 
create volume scenario, warnings will not be shown.
Line 280:         forceWarningLabel.setVisible(false);
Line 281: 
Line 282:         object.getForce().getEntityChangedEvent().addListener(new 
IEventListener() {
Line 283:             @Override


-- 
To view, visit http://gerrit.ovirt.org/21493
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55ba2d05422f0a09c242e22e8ae3467e710065b7
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to