Ori Liel has posted comments on this change.
Change subject: restapi: Remove Generic Interfaces that interfere with RSDL
......................................................................
Patch Set 1:
I don't agree that this is a shortcut; I believe the code is simpler and more
straight forward without the generic interfaces that I've removed - both for
the programmer, and the rsdl builder.
But I have no problem going about this another way. The thing is, I'm really
pressed for time. Do you think you can help?
This patch fixes two regressions:
1) can't get:
...api/vms/{vm:id}/disks/
...api/vms/{vm:id}/nics/
2) RSDL says that:
...api/vms/{vm:id}/disks/{disk:id} returns CdRom
...api/vms/{vm:id}/nics/{nic:id} returns CdRom
I'll explain to you in an email the reason for these regressions. If you find
another way to solve this, then I'll abandon this patch, a bit sadly because I
really believe this refactoring simplifies things.
Thanks,
Ori
--
To view, visit http://gerrit.ovirt.org/3862
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8753799154d06983935a805c80e0b48b7d89de0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
