Allon Mureinik has posted comments on this change. Change subject: engine-core: valueValidationFunction cleanup ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/AdGroupConditionFieldAutoCompleter.java Line 26: curList.add(charValidation); the add results in a list of size 1 that only contains charValidation. I suggest the following: Instead of: List<ValueValidationFunction> curList = new ArrayList<ValueValidationFunction>(1); curList.add(charValidation); Use: List<ValueValidationFunction> curList = Collections.singletonList(charValidation); -- To view, visit http://gerrit.ovirt.org/2816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85ce6f930834a5ba8a207345e45d088f4b9fd0ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
