Allon Mureinik has uploaded a new change for review. Change subject: core: Remove unused QueryData.type property ......................................................................
core: Remove unused QueryData.type property This property is saved in the object but never used afterwards, therefore it's redundant and should be removed. This patch removes the property, its getter, and the constructor argument that initializes it. Change-Id: I4b6cb8d9d94862fc2b66fdb1031835c4ed222f2a Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueryData.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 2 files changed, 1 insertion(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/72/21672/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueryData.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueryData.java index af2f1af..fa01c8d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueryData.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueryData.java @@ -3,15 +3,13 @@ import java.util.Date; public class QueryData { - public QueryData(String query, String type, Date date, String domain) { + public QueryData(String query, Date date, String domain) { this.query = query; - this.type = type; this.date = date; this.domain = domain; } private final String query; - private final String type; private final Date date; private final String domain; @@ -25,10 +23,6 @@ public String getQueryForAdBroker() { return query; - } - - public String getQType() { - return type; } public Date getDate() { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java index 75fdf6c..a18187f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java @@ -360,7 +360,6 @@ // An expression is considered safe if matches a trivial search. data = new QueryData(curSyntaxChecker.generateQueryFromSyntaxContainer(searchObj, isSafe), - searchObj.getSearchObjectStr(), new Date(), queryDomain); // when looking for tags , the query contains all parent children tag id's -- To view, visit http://gerrit.ovirt.org/21672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4b6cb8d9d94862fc2b66fdb1031835c4ed222f2a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches