[Engine-patches] Change in ovirt-engine[master]: webadmin: Optimize iteration over map (Findbugs)

[lvernia]

Lior Vernia has uploaded a new change for review.

Change subject: webadmin: Optimize iteration over map (Findbugs)
......................................................................

webadmin: Optimize iteration over map (Findbugs)

Replaced the iteration over the map keys with an iteration over its
entries, as a response to Findbugs warning WMI_WRONG_MAP_ITERATOR.

Change-Id: I767b72fecfb8ec76d9c259f1b059c243ecf421fb
Signed-off-by: Lior Vernia <lver...@redhat.com>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/50/21650/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java
index db911b6..eaee588 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java
@@ -131,13 +131,15 @@
             public void onSuccess(Object model, Object returnValue) {
                 Map<Network, Set<Guid>> externalNetworkToDataCenters = 
(Map<Network, Set<Guid>>) returnValue;
                 List<ExternalNetwork> items = new 
LinkedList<ExternalNetwork>();
-                for (Network network : externalNetworkToDataCenters.keySet()) {
+                for (Map.Entry<Network, Set<Guid>> entry : 
externalNetworkToDataCenters.entrySet()) {
+                    Network network = entry.getKey();
+                    Set<Guid> attachedDataCenters = entry.getValue();
+
                     ExternalNetwork externalNetwork = new ExternalNetwork();
                     externalNetwork.setNetwork(network);
                     externalNetwork.setDisplayName(network.getName());
                     externalNetwork.setPublicUse(true);
 
-                    Set<Guid> attachedDataCenters = 
externalNetworkToDataCenters.get(network);
                     List<StoragePool> availableDataCenters = new 
LinkedList<StoragePool>();
                     for (StoragePool dc : dataCenters) {
                         if (!attachedDataCenters.contains(dc.getId())) {


-- 
To view, visit http://gerrit.ovirt.org/21650
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I767b72fecfb8ec76d9c259f1b059c243ecf421fb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches