Juan Hernandez has posted comments on this change.
Change subject: core: Use DbGroup to add permissions
......................................................................
Patch Set 5:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AdGroupsHandlingCommandBase.java
Line 53: protected String getDescription() {
Line 54: return getAdGroupName();
Line 55: }
Line 56:
Line 57: // TODO to be removed
I think we can't remove it, as it is abstract in the parent and isn't
implemented in the derived classes. We may however remove the comment.
Line 58: @Override
Line 59: public List<PermissionSubject> getPermissionCheckSubjects() {
Line 60: return Collections.singletonList(new
PermissionSubject(getGroupId(), VdcObjectType.User,
Line 61: getActionType().getActionGroup()));
--
To view, visit http://gerrit.ovirt.org/19481
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae84e0bd42c8171366fa09121f66243f9b98ad2d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
