Yaniv Bronhaim has uploaded a new change for review. Change subject: core: Removing leftover of rootPassword ......................................................................
core: Removing leftover of rootPassword On host install action (or reinstall) we validated that rootPassword parameter is passed. This validation is a leftover of previous implementation. Currently all parameters in reinstall action are optional. Change-Id: I675b349313c422d13a8f46f8d3aa1eca456ee90a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1029050 Signed-off-by: Yaniv Bronhaim <ybron...@redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java 2 files changed, 0 insertions(+), 15 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/89/21589/1 diff --git a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java index 062a35e..c8fac28 100644 --- a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java +++ b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java @@ -109,8 +109,6 @@ if (action.isSetImage()) { params.setoVirtIsoFile(action.getImage()); } - } else { - validateParameters(action, "rootPassword"); } return doAction(VdcActionType.UpdateVds, params, diff --git a/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java b/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java index 1fcd645..cc071b8 100644 --- a/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java +++ b/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java @@ -527,19 +527,6 @@ } @Test - public void testIncompleteInstall() throws Exception { - setUpGetEntityWithNoCertificateInfoExpectations(1); - setUriInfo(setUpBasicUriExpectations()); - control.replay(); - try { - resource.install(new Action()); - fail("expected WebApplicationException on incomplete parameters"); - } catch (WebApplicationException wae) { - verifyIncompleteException(wae, "Action", "install", "rootPassword"); - } - } - - @Test public void testIncompleteFence() throws Exception { setUriInfo(setUpBasicUriExpectations()); control.replay(); -- To view, visit http://gerrit.ovirt.org/21589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I675b349313c422d13a8f46f8d3aa1eca456ee90a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
