Alissa Bonas has posted comments on this change.

Change subject: engine: [cleanup] Rename RunPublicQuery to runPublicQuery
......................................................................


Patch Set 2:

(1 comment)

....................................................
File 
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
Line 61: 
Line 62:     @Override
Line 63:     public VdcQueryReturnValue RunPublicQuery(VdcQueryType queryType,
Line 64:             VdcQueryParametersBase params) {
Line 65:         log.debug("Server: RunPublicQuery invoked! " + queryType); 
//$NON-NLS-1$
please fix it here as well (though generally speaking mentioning method name in 
log is redundant since log4j prints it anyway, but that is not relevant to your 
change)
Line 66:         debugQuery(queryType, params);
Line 67:         return getBackend().runPublicQuery(queryType, params);
Line 68:     }
Line 69: 


-- 
To view, visit http://gerrit.ovirt.org/21548
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If105d68de5ad76d61a9123efac5c14440a8a3032
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to