Alissa Bonas has posted comments on this change. Change subject: engine: [cleanup] Rename RunAction to runAction ......................................................................
Patch Set 2: (1 comment) .................................................... Commit Message Line 5: CommitDate: 2013-11-22 16:01:32 -0500 Line 6: Line 7: engine: [cleanup] Rename RunAction to runAction Line 8: Line 9: Backend.java:347, NM_METHOD_NAMING_CONVENTION, Priority: Low I would add (here and in all other similar patches) that this is findbugs error code, not everyone knows where this constant is coming from. Line 10: Line 11: The method name Line 12: org.ovirt.engine.core.bll.Backend.RunAction Line 13: (VdcActionType, VdcActionParametersBase) -- To view, visit http://gerrit.ovirt.org/21545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63cc50dcfdd85f97ee55e5bca37982c78fd5e949 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
