Alissa Bonas has posted comments on this change. Change subject: engine: [cleanup] Remove unused function RunAutoQuery ......................................................................
Patch Set 2: (1 comment) .................................................... Commit Message Line 10: Line 11: The method name Line 12: org.ovirt.engine.core.bll.Backend.RunAutoQuery(VdcQueryType, Line 13: VdcQueryParametersBase) Line 14: doesn't start with a lower case letter I think that if a method is removed, the explanation about it not starting with lowercase letter is not very relevant, it just makes a long commit message. IMHO just state that removing an unused method, and that "on the way" it cleans a findbug warning of type XYZ Line 15: Line 16: Methods should be verbs, in mixed case with the first letter lowercase, Line 17: with the first letter of each internal word capitalized. Line 18: -- To view, visit http://gerrit.ovirt.org/21550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5389865d16a157aff32705c7493f71e19084536 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
