Gilad Chaplik has posted comments on this change.

Change subject: webadmin: change search to be case-insensitive
......................................................................


Patch Set 1:

(3 comments)

missing VM model

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterHostListModel.java
Line 62: 
Line 63:     @Override
Line 64:     protected void syncSearch()
Line 65:     {
Line 66:         SearchParameters tempVar = new 
SearchParameters(getSearchString(), SearchType.VDS, isCaseSensitiveSearch());
this model is not influenced by the searchbar, you can remove it from patch.
Line 67:         tempVar.setRefresh(getIsQueryFirstTime());
Line 68:         super.syncSearch(VdcQueryType.Search, tempVar);
Line 69:     }
Line 70: 


....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterVmListModel.java
Line 41: 
Line 42:     @Override
Line 43:     protected void syncSearch()
Line 44:     {
Line 45:         SearchParameters tempVar = new 
SearchParameters(getSearchString(), SearchType.VM, isCaseSensitiveSearch());
also here.
Line 46:         tempVar.setRefresh(getIsQueryFirstTime());
Line 47:         super.syncSearch(VdcQueryType.Search, tempVar);
Line 48:     }
Line 49: 


....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/AlertListModel.java
Line 37:                 alertListModel.setItems(list);
Line 38:             }
Line 39:         };
Line 40: 
Line 41:         SearchParameters tempVar = new SearchParameters("Events: 
severity=alert", SearchType.AuditLog, isCaseSensitiveSearch()); //$NON-NLS-1$
also here.
Line 42:         tempVar.setMaxCount(getSearchPageSize());
Line 43:         tempVar.setRefresh(false);
Line 44:         SearchParameters searchParameters = tempVar;
Line 45: 


-- 
To view, visit http://gerrit.ovirt.org/21213
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2c5f48cf565533c330c80a02ee24596ee039e2d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to