Michael Pasternak has posted comments on this change. Change subject: packaging: api: redirect /api to /ovirt-engine/api using rewrite rules ......................................................................
Patch Set 1: Code-Review-1 (2 comments) .................................................... File backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml Line 26: <session-config> Line 27: <session-timeout>180</session-timeout> Line 28: <cookie-config> Line 29: <path>/</path> Line 30: </cookie-config> why do we need this? if the authentication happens in /ovirt-engine/api* no need to set cookie for / Line 31: </session-config> .................................................... File packaging/services/ovirt-engine/ovirt-engine.xml.in Line 308: #end if Line 309: <virtual-server name="default-host" enable-welcome-root="false"> Line 310: <alias name="localhost"/> Line 311: <rewrite pattern="^/RHEVManager(.*)$" substitution="/OvirtEngine$1" flags="last"/> Line 312: <rewrite pattern="^/api(.*)$" substitution="/ovirt-engine/api$1" flags="last"/> IIUC, it wont append matrix parameters when rewrites URL Line 313: </virtual-server> Line 314: </subsystem> Line 315: Line 316: </profile> -- To view, visit http://gerrit.ovirt.org/21566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ad9bb362719c7805be9f69d7e14bd3ad7b1f5c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
