Sandro Bonazzola has posted comments on this change. Change subject: WIP: packaging: setup: re-write using otopi ......................................................................
Patch Set 1: (1 comment) .................................................... File packaging/setup/ovirt_engine_setup/dwh_constants.py Line 124: @util.export Line 125: class FileLocations(object): Line 126: SYSCONFDIR = '/etc' Line 127: LOCALSTATEDIR = '/var' Line 128: DATADIR = '/usr/share' DWH is not engine, I would like to avoid to rely on engine environment constants where it is possible. Line 129: Line 130: DWH_CONFIG_DIR = dwh_config.DWH_SYSCONFDIR Line 131: DWH_DB_SCRIPT_DIR = os.path.join( Line 132: dwh_config.DWH_DATADIR, -- To view, visit http://gerrit.ovirt.org/21380 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f07eb3f93d884f806603e5e9c7f2c577c17dc98 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
