Ravi Nori has uploaded a new change for review. Change subject: webadmin: fix Edit Role dialog layout ......................................................................
webadmin: fix Edit Role dialog layout "Edit Role" dialog layout has several issues Change-Id: Ib73c20096b537ad06168b7402d74a19f74188a91 Bug-Url: https://bugzilla.redhat.com/1025203 Signed-off-by: Ravi Nori <rn...@redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.ui.xml 1 file changed, 42 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/28/21528/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.ui.xml b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.ui.xml index b525e8d..ef2597d 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.ui.xml +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.ui.xml @@ -4,8 +4,37 @@ xmlns:d="urn:import:org.ovirt.engine.ui.common.widget.dialog" xmlns:e="urn:import:org.ovirt.engine.ui.common.widget.editor" xmlns:we="urn:import:org.ovirt.engine.ui.webadmin.widget.editor"> -<ui:style> - + <ui:style> + .titleLabel { + padding-top: 5px; + } + + .explanationLabel { + padding-top: 5px; + padding-left: 5px; + padding-bottom: 5px; + } + + .treePanel { + margin-top: 5px; + } + + .buttonPanel { + padding-left: 5px; + vertical-align: middle; + } + + .radioButton { + vertical-align: middle; + } + + .radioButton label { + vertical-align: middle; + position: relative; + padding-bottom: 7px; + padding-left: 1px; + padding-right: 2px; + } </ui:style> <d:SimpleDialogPanel width="650px" height="500px"> @@ -14,18 +43,20 @@ <g:FlowPanel> <g:HorizontalPanel> <e:EntityModelTextBoxEditor ui:field="nameEditor" /> - <e:EntityModelTextBoxEditor ui:field="descriptionEditor" /> + <e:EntityModelTextBoxEditor ui:field="descriptionEditor"/> </g:HorizontalPanel> - <g:HorizontalPanel> - <g:Label ui:field="accountTypeLabel"/> - <g:RadioButton name="accountTypeRadioButton" ui:field="userRadioButtonEditor"/> - <g:RadioButton name="accountTypeRadioButton" ui:field="adminRadioButtonEditor"/> + <g:HorizontalPanel addStyleNames="{style.buttonPanel}"> + <g:Label ui:field="accountTypeLabel" addStyleNames="{style.titleLabel}"/> + <g:RadioButton name="accountTypeRadioButton" ui:field="userRadioButtonEditor" addStyleNames="{style.radioButton}"/> + <g:RadioButton name="accountTypeRadioButton" ui:field="adminRadioButtonEditor" addStyleNames="{style.radioButton}"/> </g:HorizontalPanel> <g:HTML><hr style="width:100%;" /></g:HTML> - <g:Label ui:field="explainationLabel"/> - <g:Button ui:field="expandAllButton"/> - <g:Button ui:field="collapseAllButton"/> - <g:ScrollPanel height="250px"> + <g:Label ui:field="explainationLabel" addStyleNames="{style.explanationLabel}"/> + <g:HorizontalPanel addStyleNames="{style.buttonPanel}"> + <g:Button ui:field="expandAllButton"/> + <g:Button ui:field="collapseAllButton"/> + </g:HorizontalPanel> + <g:ScrollPanel height="300px" addStyleNames="{style.treePanel}"> <we:EntityModelCellTree ui:field="tree"/> </g:ScrollPanel> </g:FlowPanel> -- To view, visit http://gerrit.ovirt.org/21528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib73c20096b537ad06168b7402d74a19f74188a91 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
