Martin Peřina has posted comments on this change.
Change subject: core: Move VDS to Maintenance only if StopSPM is successful
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java
Line 59: }
Line 60: }
Line 61:
Line 62: private void MoveVdssToGoingToMaintenanceMode() {
Line 63: List<VDS> nonSpms = new LinkedList<>();
I would rather not, because:
1) If removing from vdssToMaintenance is handled in
MoveVdssToGoingToMaintenanceMode(), then it should be done on two places (for
nonSpms and spms separately)
2) If removing from vdssToMaintenance is handled in
setVdsStatusToPrepareForMaintaice, then I would have to pass an iterator into
this method to be able to remove if an error
Line 64: List<VDS> spms = new LinkedList<>();
Line 65: for(VDS vds : vdssToMaintenance.values()) {
Line 66: if (vds.getSpmStatus() == VdsSpmStatus.SPM) {
Line 67: spms.add(0, vds);
--
To view, visit http://gerrit.ovirt.org/21231
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c58f9a9629d2e7a496f02c4dececeb842d44543
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
