Ravi Nori has posted comments on this change.
Change subject: engine: Change parameter type of QueriesCommandBase
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java
Line 81: StringBuilder builder = new StringBuilder(25);
Line 82: builder.append("refresh: ");
Line 83: builder.append(getRefresh());
Line 84: builder.append(", filtered: ");
Line 85: builder.append(getRefresh());
right will change
Line 86: return builder.toString();
Line 87: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VdcParameterHelper.java
Line 23:
Line 24: return childrenTasksSuccess;
Line 25: }
Line 26:
Line 27: public static VdcParametersMap buildActionParametersMap() {
In the new code we wont be using VdcActionParametersBase, but there needs to be
a default set of parameters initialized for Action. This is a builder function
that initializes the map to use in place of VdcActionParametersBase, should
probably go in VdcParametersMap
Line 28: return new VdcParametersMap().
Line 29: put(CoreVdcParameters.SHOULD_BE_LOGGED, true).
Line 30: put(CoreVdcParameters.TRANSACTION_OPTION,
TransactionScopeOption.Required).
Line 31: put(CoreVdcParameters.TASK_GROUP_SUCCESS, true).
--
To view, visit http://gerrit.ovirt.org/21481
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1992d8a2af4af96b01f2e6b3cc1684b82159e230
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
