Ravi Nori has posted comments on this change.
Change subject: engine : Remove GetAllServerCpuListParameters class
......................................................................
Patch Set 16:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllServerCpuListQuery.java
Line 53: //}
Line 54:
Line 55: public class GetAllServerCpuListQuery<P extends VdcParametersMap>
extends QueriesCommandBase<P> {
Line 56:
Line 57: VdcParameter[] requiredParameters = {CoreVdcParameters.Version};
Will change
Line 58:
Line 59: public GetAllServerCpuListQuery(P parameters) {
Line 60: super(parameters);
Line 61: setRequiredParameters(requiredParameters);
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/CoreVdcParameters.java
Line 34: public final static VdcParameter ENTITY_INFO =
create("ENTITY_INFO", EntityInfo.class, "ad5c277c-d227-4f79-b4f1-f913f89a0363");
Line 35: public final static VdcParameter HTTP_SESSION_ID =
create("HTTP_SESSION_ID", String.class, "5aa86c5a-f6f2-417a-a1c9-fd2cb929fd35");
Line 36: public final static VdcParameter FILTERED =
create("MULTIPLE_ACTION", Boolean.class,
"0f280be8-4d79-45a5-bd7e-c8a5cf2c8cd5");
Line 37: public final static VdcParameter REFRESH =
create("MULTIPLE_ACTION", Boolean.class,
"6d83abe3-0268-47e6-b46c-283282dfe709");
Line 38: public final static VdcParameter Version = create("Version",
Version.class, "843c2b96-de68-4aef-ac86-aecdea6fff95");
:) will change to upper case.
I think core is the right place for this, any suggestions?
Line 39:
--
To view, visit http://gerrit.ovirt.org/20416
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifedb114e8a2294bb3868077c0d3466557b1b8d45
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
