Tomas Jelinek has uploaded a new change for review.
Change subject: frontend: clear invalid color on DialogTab
......................................................................
frontend: clear invalid color on DialogTab
markAsInvalid() sets the border to "red" in AbstractValidatedWidget.
If after marking something as invalid the same field is marked as valid,
the DialogTab.markAsValid() did not clear this border. Consequently, if some
validation failed, the side tabs stayed red forever.
Change-Id: Ia5e0f92112d62295aef9b82424f3dd5f8097ebc0
Signed-off-by: Tomas Jelinek <tjeli...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTab.java
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/17/21517/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTab.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTab.java
index 9409317..c83b851 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTab.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTab.java
@@ -57,6 +57,7 @@
@Override
public void markAsValid() {
+ getValidatedWidgetStyle().clearBorderColor();
tabContainer.getElement().addClassName(isActive ?
style.obrand_active() : style.inactive());
}
--
To view, visit http://gerrit.ovirt.org/21517
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5e0f92112d62295aef9b82424f3dd5f8097ebc0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
