Kanagaraj M has posted comments on this change. Change subject: engine: Fixed issue with gluster task cleanup ......................................................................
Patch Set 1: Code-Review+1 (1 comment) minor comment .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java Line 264: */ Line 265: private void cleanUpOrphanTasks(Map<Guid, Set<Guid>> runningTasksinClusterMap) { Line 266: //Populate the list of tasks that need to be monitored from database Line 267: List<Guid> taskListInDB = getProvider().getMonitoredTaskIDsInDB(); Line 268: if (taskListInDB == null || taskListInDB.isEmpty()) { you could return in case runningTasksinClusterMap is empty Line 269: return; Line 270: } Line 271: Line 272: Set<Guid> allRunningTasksInCluster = new HashSet<>(); -- To view, visit http://gerrit.ovirt.org/21497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70cc24e278d112d889dc2d08ee72fce22a457195 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches