Eoghan Glynn has posted comments on this change. Change subject: restapi: Added Gluster entities in REST schema ......................................................................
Patch Set 13: Hi Shireesh, Thanks for moving the whitespace changes, looks good. On the unsignedInt versus unsignedShort - are you confident that 65535 is a sufficient upper bound for both counts? (this limit is not enforced at the Java level, but that's what the XSD type means - an unsigned value that fits into 16 bits). Cheers, Eoghan -- To view, visit http://gerrit.ovirt.org/3360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93c4df85068c3ed1ebfa35124bdfc2ae8f4482c8 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Eoghan Glynn <eoghan.gl...@gmail.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
