Michael Pasternak has posted comments on this change.
Change subject: webadmin: Use /api/ instead of /api
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java
Line 69: this.eventBus = eventBus;
Line 70: this.clientStorage = clientStorage;
Line 71: // Note that the slash at the end of the URL is not just a
whim. With the trailing slash the browser will only
Line 72: // send authentication headers to URLs ending in api/,
otherwise it will send them to URLs ending in /, and
Line 73: // this causes problems in other applications, for example in
the reports application.
there is no credentials send here, only cookie, and today cookie has path=/,
not sure i understand the problem, nor solution,
maybe i'm missing something ?
Line 74: this.restApiBaseUrl = FrontendUrlUtils.getRootURL() + "api/";
//$NON-NLS-1$
Line 75: }
Line 76:
Line 77: void sendRequest(RequestBuilder requestBuilder, RestApiCallback
callback) {
--
To view, visit http://gerrit.ovirt.org/21431
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I096a8769ff018f60366ab4ec8d2425c7f8d0f7e2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
