Eyal Edri has posted comments on this change.
Change subject: Add new job update-engine-params
......................................................................
Patch Set 31:
(1 comment)
....................................................
File jobs/ovirt_engine_upgrade_params/update_engine_params.sh
Line 164:
Line 165:
Line 166: check_engine_status()
Line 167: {
Line 168: sleep 60
of course it shouldn't run forever, it should have a timeout to die after x
seconds.'
i would suggest waiting 60 sec and die if we don't get 200 OK.
Line 169: local _password=$(grep -i 'OVESETUP_DB/password' ${ANS_FILE} \
Line 170: | awk -F':' '{print
$NF}')
Line 171: local _status=$(curl --user "admin@internal:${_password}" \
Line 172: -I \
--
To view, visit http://gerrit.ovirt.org/21094
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1809bd55c88b17f1d7dfde3920212e6f046709a8
Gerrit-PatchSet: 31
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
