Sahina Bose has posted comments on this change.
Change subject: gluster: Update task status everytime while querying
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRemoveBricksStatusQuery.java
Line 71:
Line 72: // Update the latest status details for task steps.
Line 73: // This is required to make sure the engine details are
up-to-date
Line 74: asyncTask.setStatus(entity.getStatusSummary().getStatus());
Line 75:
getGlusterTaskUtils().updateSteps(getClusterDao().get(clusterId), asyncTask,
stepsList);
Shouldn't you pass the task object obtained from VDSM, rather than the one
obtained from db?
Line 76:
Line 77: // release the volume lock if the task is completed
Line 78: if (getGlusterTaskUtils().hasTaskCompleted(asyncTask)) {
Line 79: getGlusterTaskUtils().releaseLock(volume.getId());
--
To view, visit http://gerrit.ovirt.org/21005
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e8fa7ab590e15ee5821ae2f3fb41650c195c0fa
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
