Greg Sheremeta has uploaded a new change for review. Change subject: userportal, webadmin: run favicon bug workaround in Scheduler ......................................................................
userportal, webadmin: run favicon bug workaround in Scheduler Run the Firefox favicon bug workaround in GWT Scheduler, since GWT-P place transition implementation uses deferred commands. Change-Id: I73278382894d02970022ceef8b95d8c2f3b62ec0 Bug-Url: https://bugzilla.redhat.com/999436 Signed-off-by: Greg Sheremeta <gsher...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/place/ApplicationPlaceManager.java 1 file changed, 13 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/34/21434/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/place/ApplicationPlaceManager.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/place/ApplicationPlaceManager.java index 61e097a..0da80f5 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/place/ApplicationPlaceManager.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/place/ApplicationPlaceManager.java @@ -7,6 +7,8 @@ import org.ovirt.engine.ui.common.auth.UserLoginChangeEvent.UserLoginChangeHandler; import org.ovirt.engine.ui.common.uicommon.ClientAgentType; +import com.google.gwt.core.client.Scheduler; +import com.google.gwt.core.client.Scheduler.ScheduledCommand; import com.google.gwt.dom.client.Node; import com.google.gwt.event.logical.shared.ValueChangeEvent; import com.google.gwt.event.shared.EventBus; @@ -48,12 +50,17 @@ public void onValueChange(ValueChangeEvent<String> event) { super.onValueChange(event); if ("firefox".equalsIgnoreCase(clientAgentType.getBrowser())) { //$NON-NLS-1$ - Node favicon = DOM.getElementById("id-link-favicon"); //$NON-NLS-1$ - if (favicon != null) { - Node parent = favicon.getParentNode(); - favicon.removeFromParent(); - parent.appendChild(favicon); - } + Scheduler.get().scheduleDeferred(new ScheduledCommand() { + @Override + public void execute() { + Node favicon = DOM.getElementById("id-link-favicon"); //$NON-NLS-1$ + if (favicon != null) { + Node parent = favicon.getParentNode(); + favicon.removeFromParent(); + parent.appendChild(favicon); + } + } + }); } } -- To view, visit http://gerrit.ovirt.org/21434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I73278382894d02970022ceef8b95d8c2f3b62ec0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
