Gilad Chaplik has posted comments on this change.
Change subject: engine: Inform the user when the external scheduler is
unavailable
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
minor comments.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java
Line 74: Map<String, String> propertiesMap) {
Line 75:
Line 76: try {
Line 77: // Do not call the scheduler when there is no operation
requested from it
Line 78: if (filterNames.isEmpty()) return hostIDs;
please add parentheses and spit to lines.
Line 79:
Line 80: XmlRpcClient client = new XmlRpcClient();
Line 81: client.setConfig(config);
Line 82: Object result = client.execute(FILTER,
createFilterArgs(filterNames, hostIDs, vmID, propertiesMap));
Line 84:
Line 85: } catch (XmlRpcException e) {
Line 86: log.error("Could not communicate with the external
scheduler while filtering", e);
Line 87: AuditLogableBase loggable = new AuditLogableBase();
Line 88: AuditLogDirector.log(loggable,
AuditLogType.FAILED_TO_CONNECT_TO_SCHEDULER_PROXY);
extract to a method, auditLogFailedToConnect() or sth like that.
Line 89: return hostIDs;
Line 90: }
Line 91: }
Line 92:
Line 129: Guid vmID,
Line 130: Map<String, String> propertiesMap) {
Line 131: try {
Line 132: // Do not call the scheduler when there is no operation
requested from it
Line 133: if (scoreNameAndWeight.isEmpty()) return null;
same.
Line 134:
Line 135: XmlRpcClient client = new XmlRpcClient();
Line 136: client.setConfig(config);
Line 137: Object result = client.execute(SCORE,
createScoreArgs(scoreNameAndWeight, hostIDs, vmID, propertiesMap));
--
To view, visit http://gerrit.ovirt.org/21416
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a3e56e9a8db16b58305b2ebdc2b8041297da093
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
