Martin Peřina has posted comments on this change. Change subject: core: Add internal authenticator ......................................................................
Patch Set 1: (1 comment) .................................................... File backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/internal/InternalDirectory.java Line 23: Line 24: // The identifier of the admin user of the internal directory is inserted in the database when it is created, we Line 25: // need to use exactly the same here: Line 26: private static final ExternalId ADMIN_ID = new ExternalId( Line 27: 0xfd, 0xfc, 0x62, 0x7c, 0xd8, 0x75, 0x11, 0xe0, 0x90, 0xf0, 0x83, 0xdf, 0x13, 0x3b, 0x58, 0xcc Shouldn't this id be also placed in Config? Line 28: ); Line 29: Line 30: // The only user supported by this directory: Line 31: private DirectoryUser admin; -- To view, visit http://gerrit.ovirt.org/21029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I005e7e721b6342b292cf79ccf1e0355c65bd116f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
