Tal Nisan has posted comments on this change.
Change subject: core: rename to lowercase method in CommandBase
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1605: p.setEntityInfo(getParameters().getEntityInfo());
Line 1606: return createTask(internalGetTaskType(), p);
Line 1607: }
Line 1608:
Line 1609: public SPMAsyncTask createTask(AsyncTaskType taskType,
AsyncTaskParameters taskParameters) {
If that's the only usage it can be made private
Line 1610: return AsyncTaskFactory.construct(taskType, taskParameters,
false);
Line 1611: }
Line 1612:
Line 1613: private AsyncTasks getAsyncTask(
--
To view, visit http://gerrit.ovirt.org/21404
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c34fe5f96b77902e6bdaa04ad974c470909e8c6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
