Doron Fediuck has posted comments on this change.
Change subject: Failing plugin should not cause an empty host list to be
returned
......................................................................
Patch Set 2:
(2 comments)
See inline some minor yet needed comments
....................................................
File src/ovirtscheduler/request_handler.py
Line 112: def aggregate_filter_results(self, filterRunners):
Line 113: resultSet = set(filterRunners)
Line 114: for runner in filterRunners:
Line 115:
Line 116: # if the filter fails, ignore it anc continue
s/anc/and/
Line 117: # as if it was not there
Line 118: if runner.getReturnCode() or runner.getErrors():
Line 119: self._logger.warn('Error in %s', runner._script)
Line 120: continue
Line 167: def aggregate_score_results(self, scoreRunners):
Line 168: results = {}
Line 169: for runner, weight in scoreRunners:
Line 170: # if the scoring function fails, ignore the result
Line 171: if runner.getReturnCode() != 0 or runner.getErrors:
Can you please log it, so we'll know there is a problem and can debug it?
Line 172: continue
Line 173:
Line 174: hostScores = runner.getResults()
Line 175: if hostScores is None:
--
To view, visit http://gerrit.ovirt.org/21232
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1a38e7007cd50f261290bf5f31b85cb9c8c6314
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-scheduler-proxy
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
