Vojtech Szocs has posted comments on this change. Change subject: userportal, webadmin: workaround for Firefox favicon bug ......................................................................
Patch Set 6: Code-Review+2 > Thanks. All set. final is a weird use for an invariant for me, but I'll get > used to it. In Spring, I'd use @Required for verifying injection. Thanks, Greg. Well, I think of "final" as something to help us ensure "something != null" throughout the lifetime of an object, which is a typical requirement for any construction-time dependency of given class. Annotations such as @Required definitely state the intention in a much clearer way, I agree with that. However, @Required assumes the class is managed by some sort of container, like Spring IoC, which is essentially an implicit dependency on container itself (might be a good or bad thing, depending on how you look at it). This also reminds me of a nice little project called Cofoja http://code.google.com/p/cofoja/ - there was a time when I considered porting it for GWT, but I never got to it. Anyway, +2 it is, patch looks good. -- To view, visit http://gerrit.ovirt.org/20798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4b0d8a0176eb9299aec01ae6772297409ef3108 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
