Roy Golan has posted comments on this change.
Change subject: core: don't skip storagePoolStatusChange call
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 591: // If VDS is in initialize status, wait for it to be up
(or until
Line 592: // configurable timeout is reached)
Line 593: waitForVdsIfIsInitializing(curVdsId);
Line 594: // update pool status to problematic while selecting spm
Line 595: try {
no mistake there, I *am* referring to the pool. the domain status will change
to UNKNOWN only if the pool status is NonResponsive || NonOperational
if there is a non-spm host which sees the domains, it should probably be
selected as an SPM.
The ping-pong of the statuses is not a desiarable side effect but this make the
system behave better.
lets think about how to avoid that ping pong in status - even though its
expected to be a short period of time, unlesss the SPM host is stuck for a long
time due to some serious problems
Line 596: ResourceManager
Line 597: .getInstance()
Line 598: .getEventListener()
Line 599: .storagePoolStatusChange(_storagePoolId,
StoragePoolStatus.NonResponsive,
--
To view, visit http://gerrit.ovirt.org/20527
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37741911c8e22f7534516d3ed8bccca6b311dc92
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
