Vojtech Szocs has posted comments on this change. Change subject: webadmin : Fixed allignment issues in Hosts General sub-tab ......................................................................
Patch Set 7: Hi, please have a look at patch http://gerrit.ovirt.org/#/c/21289/ If you rebase this patch on top of above mentioned patch, you could easily replace all ValueLabels (and any classes extending ValueLabel) with classes extending TextBoxLabelBase, for example: public class VersionTextBoxLabel extends TextBoxLabelBase<RpmVersion> { public VersionTextBoxLabel() { super(new VersionRenderer()); // reuse renderer from VersionLabel } } Our goal is to have consistent look & feel across all "General" sub tabs, we should therefore prefer TextBoxLabelBase in favor of ValueLabel. -- To view, visit http://gerrit.ovirt.org/20964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba34398f6972f90d81d76196e060c9184665dd22 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
