Alissa Bonas has uploaded a new change for review.
Change subject: core: rename methods to lowercase in SyntaxCheckerFactory
......................................................................
core: rename methods to lowercase in SyntaxCheckerFactory
Change-Id: Icaf97c5dff9c859b9189a66d484ab9489e00cc2f
Signed-off-by: Alissa Bonas <abo...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
M
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactory.java
M
backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactoryTest.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java
4 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/52/21352/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
index 8f1e5e4..73cded6 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
@@ -320,11 +320,11 @@
} else {
queryDomain = getDefaultDomain();
}
- curSyntaxChecker =
SyntaxCheckerFactory.CreateADSyntaxChecker(Config
- .<String>
GetValue(ConfigValues.AuthenticationMethod));
+ curSyntaxChecker =
SyntaxCheckerFactory.createADSyntaxChecker(Config
+
.<String>GetValue(ConfigValues.AuthenticationMethod));
} else {
curSyntaxChecker = SyntaxCheckerFactory
- .CreateBackendSyntaxChecker(Config.<String>
GetValue(ConfigValues.AuthenticationMethod));
+
.createBackendSyntaxChecker(Config.<String>GetValue(ConfigValues.AuthenticationMethod));
}
SyntaxContainer searchObj =
curSyntaxChecker.analyzeSyntaxState(searchText, true);
// set the case-sensitive flag
diff --git
a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactory.java
b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactory.java
index aee08cb..0a9e441 100644
---
a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactory.java
+++
b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactory.java
@@ -13,12 +13,12 @@
// This method is for used in client side by uicommon, which cannot access
// server side config, so needs to get the auth method as a parameter.
- public static ISyntaxChecker CreateUISyntaxChecker(String
AuthenticationMethod) {
+ public static ISyntaxChecker createUISyntaxChecker(String
AuthenticationMethod) {
ConfigAuthenticationMethod = AuthenticationMethod;
return uiSyntaxChecker;
}
- public static ISyntaxChecker CreateBackendSyntaxChecker(String
AuthenticationMethod) {
+ public static ISyntaxChecker createBackendSyntaxChecker(String
AuthenticationMethod) {
ConfigAuthenticationMethod = AuthenticationMethod;
if(backendSyntaxChecker == null) {
backendSyntaxChecker = new SyntaxChecker(Config.<Integer>
GetValue(ConfigValues.SearchResultsLimit));
@@ -26,7 +26,7 @@
return backendSyntaxChecker;
}
- public static ISyntaxChecker CreateADSyntaxChecker(String
AuthenticationMethod) {
+ public static ISyntaxChecker createADSyntaxChecker(String
AuthenticationMethod) {
ConfigAuthenticationMethod = AuthenticationMethod;
return adSyntaxChecker;
}
diff --git
a/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactoryTest.java
b/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactoryTest.java
index 474e279..4c16820 100644
---
a/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactoryTest.java
+++
b/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactoryTest.java
@@ -14,25 +14,25 @@
@Test
public void CreateUISyntaxChecker() {
- ISyntaxChecker checker =
SyntaxCheckerFactory.CreateUISyntaxChecker("foo");
+ ISyntaxChecker checker =
SyntaxCheckerFactory.createUISyntaxChecker("foo");
Assert.assertNotNull(checker);
- Assert.assertEquals(checker,
SyntaxCheckerFactory.CreateUISyntaxChecker("foo"));
+ Assert.assertEquals(checker,
SyntaxCheckerFactory.createUISyntaxChecker("foo"));
Assert.assertEquals("foo",
SyntaxCheckerFactory.getConfigAuthenticationMethod());
}
@Test
public void CreateBackendSyntaxChecker() {
- ISyntaxChecker checker =
SyntaxCheckerFactory.CreateBackendSyntaxChecker("foo");
+ ISyntaxChecker checker =
SyntaxCheckerFactory.createBackendSyntaxChecker("foo");
Assert.assertNotNull(checker);
- Assert.assertEquals(checker,
SyntaxCheckerFactory.CreateBackendSyntaxChecker("foo"));
+ Assert.assertEquals(checker,
SyntaxCheckerFactory.createBackendSyntaxChecker("foo"));
Assert.assertEquals("foo",
SyntaxCheckerFactory.getConfigAuthenticationMethod());
}
@Test
public void CreateADSyntaxChecker() {
- ISyntaxChecker checker =
SyntaxCheckerFactory.CreateADSyntaxChecker("foo");
+ ISyntaxChecker checker =
SyntaxCheckerFactory.createADSyntaxChecker("foo");
Assert.assertNotNull(checker);
- Assert.assertEquals(checker,
SyntaxCheckerFactory.CreateADSyntaxChecker("foo"));
+ Assert.assertEquals(checker,
SyntaxCheckerFactory.createADSyntaxChecker("foo"));
Assert.assertEquals("foo",
SyntaxCheckerFactory.getConfigAuthenticationMethod());
}
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java
index 7cc333f..dc2590f 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java
@@ -73,7 +73,7 @@
{
setItems(new ObservableCollection<Object>());
syntaxChecker =
- SyntaxCheckerFactory.CreateUISyntaxChecker((String)
+ SyntaxCheckerFactory.createUISyntaxChecker((String)
AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.AuthenticationMethod));
setIsTimerDisabled(true);
--
To view, visit http://gerrit.ovirt.org/21352
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icaf97c5dff9c859b9189a66d484ab9489e00cc2f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
