Allon Mureinik has posted comments on this change.
Change subject: engine: Remove concreteStorageType property from StorageType
enum.
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageType.java
Line 31: public int getValue() {
Line 32: return this.value;
Line 33: }
Line 34:
Line 35: public boolean isConcreteStorageType() {
The distinction between a concrete storage type and a non-concrete one is still
important. That, however, does not mean we need another boolean for it.
Line 36: return this.getValue() > 0;
Line 37: }
Line 38:
Line 39: public static StorageType forValue(int value) {
--
To view, visit http://gerrit.ovirt.org/21312
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdd785ccb3c0e074f5a14bec1ee60c6d374700a1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
