Alon Bar-Lev has posted comments on this change.
Change subject: packaging: ux: avoid confusing messages on db credentials
......................................................................
Patch Set 1:
(2 comments)
....................................................
Commit Message
Line 3: AuthorDate: 2013-11-15 17:10:45 +0100
Line 4: Commit: Sandro Bonazzola <sbona...@redhat.com>
Line 5: CommitDate: 2013-11-15 17:10:45 +0100
Line 6:
Line 7: packaging: ux: avoid confusing messages on db credentials
it is still packaging setup in my opinion.
Line 8:
Line 9: removed confusing message:
Line 10: Using existing credentials
Line 11:
....................................................
File packaging/setup/plugins/ovirt-engine-setup/db/connection.py
Line 140: ),
Line 141: )
Line 142: elif not self.environment[
Line 143: osetupcons.ProvisioningEnv.POSTGRES_PROVISIONING_ENABLED
Line 144: ]:
I do not think that this module should access the provisioning environment...
Line 145: self.dialog.note(
Line 146: text=_('Using existing credentials'),
Line 147: )
Line 148:
--
To view, visit http://gerrit.ovirt.org/21311
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a83fb945c49c7c2c2b4ad49d0dbd87e42144d54
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
