Sahina Bose has posted comments on this change.

Change subject: engine: Fixed issue with gluster task scheduler thread waiting
......................................................................


Patch Set 3:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
Line 134:             @Override
Line 135:             public void run() {
Line 136:                 // the task may have been started from the CLI
Line 137:                 // need to add job to monitor
Line 138:                 TransactionSupport.executeInNewTransaction(new 
TransactionMethod<Void>() {
The createJobToMonitor - calls three BLL commands internally. And these should 
be executed within the scope of a transaction so that if an exception occurs, 
the transaction can be rolled back
Line 139: 
Line 140:                     @Override
Line 141:                     public Void runInTransaction() {
Line 142:                         try {


-- 
To view, visit http://gerrit.ovirt.org/20089
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia94a2cccece1c0a45c46bbd7cc3e1e58c9aa379f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to