anmolbabu has posted comments on this change.

Change subject: engine : populate stop time when remove brick is stopped
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRemoveBricksStatusQuery.java
Line 59:         if (asyncTask != null && asyncTask.getTaskId() != null) {
Line 60:             List<Step> stepsList = 
getStepDao().getStepsByExternalId(asyncTask.getTaskId());
Line 61:             if (stepsList != null && !stepsList.isEmpty()) {
Line 62:                 entity.setStartTime(stepsList.get(0).getStartTime());
Line 63:                 entity.setStopTime(stepsList.get(0).getEndTime());
Ok. But,I am doing that from the frontend.I'll add a check here as well.I had 
thought of having a null populated otherwise.and have a status based check in 
the ui
Line 64:             }
Line 65:         }
Line 66: 
Line 67:         // Set the host ip in status details


-- 
To view, visit http://gerrit.ovirt.org/21224
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a0fc421446d1f59708d29a21464d8344a887e51
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to