Kanagaraj M has posted comments on this change.

Change subject: webadmin : mouse hover in volumes Activities column shows a box
......................................................................


Patch Set 5:

(3 comments)

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/MenuCell.java
Line 14: import com.google.gwt.cell.client.ValueUpdater;
Line 15: import com.google.gwt.dom.client.Element;
Line 16: import com.google.gwt.dom.client.EventTarget;
Line 17: import com.google.gwt.dom.client.NativeEvent;
Line 18: import com.google.gwt.dom.client.Style.Unit;
Remove unused import
Line 19: import com.google.gwt.resources.client.ImageResource;
Line 20: import com.google.gwt.safehtml.shared.SafeHtml;
Line 21: import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
Line 22: import com.google.gwt.safehtml.shared.SafeHtmlUtils;


Line 68:             if 
(parent.getFirstChildElement().isOrHasChild(Element.as(eventTarget))) {
Line 69:                 
menuPanelPopup.asPopupPanel().showAndFitToScreen(eventX, eventY);
Line 70:             }
Line 71:         }
Line 72:         if("mouseover".equals(event.getType())) {//$NON-NLS-1$
else if
Line 73:             if (isVisible(value)) {
Line 74:                 parent.getStyle().setBorderColor("#96B7D6"); 
//$NON-NLS-1$
Line 75:             }
Line 76:         }


Line 73:             if (isVisible(value)) {
Line 74:                 parent.getStyle().setBorderColor("#96B7D6"); 
//$NON-NLS-1$
Line 75:             }
Line 76:         }
Line 77:         else {//$NON-NLS-1$
NLS not required
Line 78:             parent.getStyle().setBorderColor("transparent"); 
//$NON-NLS-1$
Line 79:         }
Line 80:     }
Line 81: 


-- 
To view, visit http://gerrit.ovirt.org/20251
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I807ac3fd92ef91f5524148f768cf176f3e811614
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to