Sahina Bose has posted comments on this change. Change subject: engine:changed AddVdsCommand to use LockManager properly ......................................................................
Patch Set 2: (2 comments) .................................................... Commit Message Line 6: Line 7: engine:changed AddVdsCommand to use LockManager properly Line 8: Line 9: Added LockIdNameAttribute and changed the error message to Line 10: a more specific error Done Line 11: Line 12: Change-Id: I6189d7f0046a943a58db9d6734c92fe462c9db52 Line 13: Bug-Url: https://bugzilla.redhat.com/998799 .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java Line 573: protected Map<String, Pair<String, String>> getExclusiveLocks() { Line 574: VDSGroup cluster = getVdsGroup(); Line 575: if (cluster != null && cluster.supportsGlusterService() && !isInternalExecution()) { Line 576: return Collections.singletonMap(cluster.getId().toString(), Line 577: LockMessagesMatchUtil.makeLockingPair(LockingGroup.GLUSTER, VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_OPERATION_INPROGRESS)); The job that syncs with gluster CLI locks the cluster only if cluster supports only gluster service. This job executes a "gluster peer status" on Gluster CLI that returns list of hosts in the cluster. This list is compared with the list of hosts in the database to check if hosts have been added or removed via CLI. We use locking group named "GLUSTER" in the job to get a lock, and Add host using UI, needs to wait for this lock. I did not understand the bit about using isGlusterSupportEnabled - where do you mean? Line 578: } Line 579: return null; Line 580: } -- To view, visit http://gerrit.ovirt.org/18350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6189d7f0046a943a58db9d6734c92fe462c9db52 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
