Michael Pasternak has posted comments on this change.

Change subject: cli: list xxx --show all - output is not well formatted(#890038)
......................................................................


Patch Set 2:

(1 comment)

....................................................
File src/ovirtcli/format/text.py
Line 240:                                                     resource_context,
Line 241:                                                     mode=mode)
Line 242:             else:
Line 243:                 for item in reduced_mode_fields:
Line 244:                     width0 = max(width0, len(item))
here you finding max len of the name of the property, not it's content ...
Line 245:             width = max(width, width0)
Line 246: 
Line 247:         return width
Line 248: 


-- 
To view, visit http://gerrit.ovirt.org/21240
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcaa28d3718f8dd0aceb3935ae2606713eee34e9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to