Roy Golan has uploaded a new change for review. Change subject: core: search vms os match and ignore case ......................................................................
core: search vms os match and ignore case search on os matched startsWith instead of equalsIgnoreCase * Added unit test coverage Change-Id: I739cad296389ef0356e204ed00b2546bd4d13c92 Signed-off-by: Roy Golan <[email protected]> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1003804 --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleter.java A backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleterTest.java 2 files changed, 43 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/56/21256/1 diff --git a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleter.java b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleter.java index f74c2f1..b4ef765 100644 --- a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleter.java +++ b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleter.java @@ -15,7 +15,7 @@ @Override public String convertFieldEnumValueToActualValue(String fieldValue) { for (Map.Entry<Integer, String> e : map.entrySet()) { - if (fieldValue.toLowerCase().startsWith(e.getValue())) { + if (fieldValue.equalsIgnoreCase(e.getValue())) { return e.getKey().toString(); } } diff --git a/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleterTest.java b/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleterTest.java new file mode 100644 index 0000000..2ba08c7 --- /dev/null +++ b/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleterTest.java @@ -0,0 +1,42 @@ +package org.ovirt.engine.core.searchbackend; + +import junit.framework.Assert; +import org.junit.Before; +import org.junit.Test; + +import java.util.HashMap; +import java.util.Map; + +public class OsValueAutoCompleterTest { + + private OsValueAutoCompleter completer; + + @Before + public void setup() { + + Map<Integer, String> completionMap = new HashMap<Integer, String>(); + completionMap.put(0, "other"); + completionMap.put(1, "rhel_x"); + completionMap.put(2, "rhel_x_y"); + completer = new OsValueAutoCompleter(completionMap); + } + + @Test + public void testCompleteSingleValue() { + Assert.assertEquals(1, completer.getCompletion("ot").length); + } + + @Test + public void testCompletionMutliReturnValue() { + Assert.assertTrue(completer.getCompletion("r").length > 1); + } + + @Test + public void testConvertStringToId() { + Assert.assertEquals("0", completer.convertFieldEnumValueToActualValue("other")); + Assert.assertEquals("1", completer.convertFieldEnumValueToActualValue("rhel_x")); + Assert.assertEquals("2", completer.convertFieldEnumValueToActualValue("rhel_x_y")); + } + + +} -- To view, visit http://gerrit.ovirt.org/21256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I739cad296389ef0356e204ed00b2546bd4d13c92 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
