Tomas Jelinek has posted comments on this change. Change subject: webadmin: Put back vNIC listener after flush ......................................................................
Patch Set 1: > That was my initial thought, but then I thought maybe it > had good reason to flush, I'm not aware of how all the > other widgets in the dialog behave - but you might be! :) yeah, I would say the reason is that there is a bug :) > But in general, I can't count on a widget being flushed > only once (when the dialog closes), right? So I think the > problem with the listener here is general, the flushing > caused by the Advanced button is only what exposed it. > Your opinion? Correct. So this patch fixes an issue so I will +2 it and try to have a look at the problem with the flushing by myself. -- To view, visit http://gerrit.ovirt.org/21242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cc1583bd629e0cf217d7e941f6fd018032831fb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
